-
-
Notifications
You must be signed in to change notification settings - Fork 428
added bogosort algorithem #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Fisher-Yates
shuffle
andisSorted
should get their own files (and tests); they are much more useful than bogosort. This will trivialize the bogosort. - Don't use
var
, uselet
andconst
instead. - The complexity analysis is wrong. The best case complexity is O(n), since a single
isSorted
check takes O(n). The (expected) average complexity is not "unbounded"; yes, it can in theory fail to find the correct permutation infinitely often, but the probability for that is 0: Each iteration has a probability of 1/n! of succeeding. You obtain an expected O(n!n) time complexity using the geometric distribution since each iteration takes O(n) time. - You need to add tests. Please try to do this without simply duplicating tests.
Thanks for reviewing so quickly, I refactored the code, added tests and change the time complexity in the latest commits. |
appgurueu
reviewed
Aug 8, 2023
appgurueu
reviewed
Aug 8, 2023
appgurueu
reviewed
Aug 8, 2023
appgurueu
approved these changes
Aug 8, 2023
raklaptudirm
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added bogosort algorithem