Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm: decimal to binary #23

Merged
merged 4 commits into from
Oct 2, 2022
Merged

algorithm: decimal to binary #23

merged 4 commits into from
Oct 2, 2022

Conversation

jonatan5524
Copy link
Contributor

closes: #17

appgurueu
appgurueu previously approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine

raklaptudirm
raklaptudirm requested changes Oct 2, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning a number is misleading imo, instead return a string.

@raklaptudirm raklaptudirm changed the title add convert binary algorithm algorithm: decimal to binary Oct 2, 2022
@raklaptudirm raklaptudirm merged commit 502e11e into TheAlgorithms:master Oct 2, 2022
@jonatan5524
Copy link
Contributor Author

@appgurueu @raklaptudirm Thank you for the merge, now I realized that the Math folder inside src and Cipher is outside of src, where it should be?

@raklaptudirm
Copy link
Member

raklaptudirm commented Oct 2, 2022 •
edited
Loading

All categories should be at the root, no need for an src directory.

@jonatan5524
Copy link
Contributor Author

All categories should be at the root, no need for an src directory.

Then I will open a new PR to fix it.

@jonatan5524 jonatan5524 mentioned this pull request Oct 3, 2022
Merged
@marvinbuff marvinbuff mentioned this pull request Oct 22, 2023
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu appgurueu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Binary Convert in Maths
3 participants
@jonatan5524 @raklaptudirm @appgurueu