Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #122

Merged
merged 13 commits into from
Apr 9, 2019
Merged

Update dependencies #122

merged 13 commits into from
Apr 9, 2019

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Mar 9, 2019

Proposed Changes

Updates dependencies that don't break the build.

For some reason when updating dotnet-mono or FSharp.Core, Windows builds fail on dotnet test saying:

Test run for C:\Users\appveyor\AppData\Local\Temp\1\0a120276395f48959749c98941a2bc4b\MyCoolLib\tests\MyCoolLib.Tests\bin\Debug\net461\MyCoolLib.Tests.exe(.NETFramework,Version=v4.6.1)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
No test is available in C:\Users\appveyor\AppData\Local\Temp\1\0a120276395f48959749c98941a2bc4b\MyCoolLib\tests\MyCoolLib.Tests\bin\Debug\net461\MyCoolLib.Tests.exe. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd changed the title WIP: Update deps3 Update dependencies Mar 10, 2019
@TheAngryByrd TheAngryByrd merged commit 16a07c6 into master Apr 9, 2019
TheAngryByrd pushed a commit that referenced this pull request Apr 9, 2019
* MAINTENANCE: Bump most dependencies (#122)
@TheAngryByrd TheAngryByrd deleted the update-deps3 branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant