Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize build.fsx #137

Merged
merged 6 commits into from
May 20, 2019
Merged

reorganize build.fsx #137

merged 6 commits into from
May 20, 2019

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Content/Library/build.fsx Outdated Show resolved Hide resolved
@baronfel
Copy link
Collaborator

LGTM. Added a single note, and we briefly talked over the weekend about investigating the use of the BuildTasks package to strongly-type and relate the tasks instead of FAKE's chaining API.

@TheAngryByrd TheAngryByrd force-pushed the reorganize-build-fsx branch from 54f6815 to d040a1a Compare May 20, 2019 21:25
@TheAngryByrd TheAngryByrd changed the title WIP: reorganize build.fsx reorganize build.fsx May 20, 2019
@TheAngryByrd TheAngryByrd merged commit cbd5a3c into master May 20, 2019
TheAngryByrd pushed a commit that referenced this pull request May 20, 2019
* MINOR: Reorganzition of build.fsx for Library and Console (#137)
@TheAngryByrd TheAngryByrd deleted the reorganize-build-fsx branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants