Set build.sh permissions in github workflow #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Could you update the |
jltrem
force-pushed
the
linux-build-permissions
branch
from
f1e75bb
to
c2919ea
Compare
jltrem
force-pushed
the
linux-build-permissions
branch
from
c2919ea
to
6554c9d
Compare
TheAngryByrd
pushed a commit
that referenced
this pull request
Jan 3, 2020
* BUGFIX: Fixup gitlab workflow ci file (#168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the build.sh permissions in the github workflow fixes the Linux build problem when the script loses its attributes on Windows.
Initially I went down the wrong path playing with the travis.yml. It specifies the build script but this is completely ignored: the github workflow takes charge.