Fixes #192

Content/Console/build.fsx

@@ -150,6 +150,16 @@ let isEmptyChange = function
     | Changelog.Change.Custom (_, s) ->
         String.IsNullOrWhiteSpace s.CleanedText
 
+let isChangelogEmpty () =
+    let isEmpty =
+        (latestEntry.Changes |> Seq.forall isEmptyChange)
+        || latestEntry.Changes |> Seq.isEmpty
+    if isEmpty then failwith "No changes in CHANGELOG. Please add your changes under a heading specified in https://keepachangelog.com/"
+
+let allReleaseChecks () =
+    isReleaseBranchCheck ()
+    isChangelogEmpty ()
+
 let mkLinkReference (newVersion : SemVerInfo) (changelog : Changelog.Changelog) =
     if changelog.Entries |> List.isEmpty then
         // No actual changelog entries yet: link reference will just point to the Git tag
@@ -465,7 +475,7 @@ let createPackages _ =
     )
 
 let gitRelease _ =
-    isReleaseBranchCheck ()
+    allReleaseChecks ()
 
     let releaseNotesGitCommitFormat = latestEntry.ToString()
 
@@ -481,6 +491,7 @@ let gitRelease _ =
     Target.deactivateBuildFailure "RevertChangelog"
 
 let githubRelease _ =
+    allReleaseChecks ()
     let token =
         match Environment.environVarOrDefault "GITHUB_TOKEN" "" with
         | s when not (String.IsNullOrWhiteSpace s) -> s

Content/Library/build.fsx

@@ -144,6 +144,17 @@ let isEmptyChange = function
     | Changelog.Change.Custom (_, s) ->
         String.IsNullOrWhiteSpace s.CleanedText
 
+let isChangelogEmpty () =
+    let isEmpty =
+        (latestEntry.Changes |> Seq.forall isEmptyChange)
+        || latestEntry.Changes |> Seq.isEmpty
+    if isEmpty then failwith "No changes in CHANGELOG. Please add your changes under a heading specified in https://keepachangelog.com/"
+
+let allReleaseChecks () =
+    isReleaseBranchCheck ()
+    isChangelogEmpty ()
+
+
 let mkLinkReference (newVersion : SemVerInfo) (changelog : Changelog.Changelog) =
     if changelog.Entries |> List.isEmpty then
         // No actual changelog entries yet: link reference will just point to the Git tag
@@ -498,7 +509,7 @@ let sourceLinkTest _ =
     )
 
 let publishToNuget _ =
-    isReleaseBranchCheck ()
+    allReleaseChecks ()
     Paket.push(fun c ->
         { c with
             ToolType = ToolType.CreateLocalTool()
@@ -510,7 +521,7 @@ let publishToNuget _ =
     Target.deactivateBuildFailure "RevertChangelog"
 
 let gitRelease _ =
-    isReleaseBranchCheck ()
+    allReleaseChecks ()
 
     let releaseNotesGitCommitFormat = latestEntry.ToString()
 
@@ -524,6 +535,7 @@ let gitRelease _ =
     Git.Branches.pushTag "" "origin" tag
 
 let githubRelease _ =
+    allReleaseChecks ()
     let token =
         match Environment.environVarOrDefault "GITHUB_TOKEN" "" with
         | s when not (String.IsNullOrWhiteSpace s) -> s
@@ -577,7 +589,7 @@ let watchDocs _ =
     DocsTool.watch ()
 
 let releaseDocs ctx =
-    isReleaseBranchCheck ()
+    isReleaseBranchCheck () // Docs changes don't need a full release to the library
 
     Git.Staging.stageAll docsDir
     Git.Commit.exec "" (sprintf "Documentation release of version %s" latestEntry.NuGetVersion)

build.fsx

@@ -126,6 +126,16 @@ let isEmptyChange = function
     | Changelog.Change.Custom (_, s) ->
         String.IsNullOrWhiteSpace s.CleanedText
 
+let isChangelogEmpty () =
+    let isEmpty =
+        (latestEntry.Changes |> Seq.forall isEmptyChange)
+        || latestEntry.Changes |> Seq.isEmpty
+    if isEmpty then failwith "No changes in CHANGELOG. Please add your changes under a heading specified in https://keepachangelog.com/"
+
+let allReleaseChecks () =
+    isReleaseBranchCheck ()
+    isChangelogEmpty ()
+
 let mkLinkReference (newVersion : SemVerInfo) (changelog : Changelog.Changelog) =
     if changelog.Entries |> List.isEmpty then
         // No actual changelog entries yet: link reference will just point to the Git tag
@@ -355,6 +365,7 @@ let ``integration tests`` ctx =
                 }) proj)
 
 let publish _ =
+    allReleaseChecks ()
     Paket.push(fun c ->
         { c with
             ToolType = ToolType.CreateLocalTool()
@@ -364,7 +375,7 @@ let publish _ =
     )
 
 let ``git release`` _ =
-    isReleaseBranchCheck ()
+    allReleaseChecks ()
 
     let releaseNotesGitCommitFormat = latestEntry.ToString()
 
@@ -379,6 +390,8 @@ let ``git release`` _ =
 
 
 let ``github release`` _ =
+    allReleaseChecks ()
+
     let token =
         match Environment.environVarOrDefault "GITHUB_TOKEN" "" with
         | s when not (String.IsNullOrWhiteSpace s) -> s
@@ -402,7 +415,7 @@ let ``watch docs`` _ =
     DocsTool.watch ()
 
 let ``release docs`` ctx =
-    isReleaseBranchCheck ()
+    isReleaseBranchCheck () // Docs changes don't need a full release to the library
 
     Git.Staging.stageAll docsDir
     Git.Commit.exec "" (sprintf "Documentation release of version %s" latestEntry.NuGetVersion)

tests/MiniScaffold.Tests/Asserts.fs

@@ -3,6 +3,25 @@ open System.IO
 open Expecto
 open Infrastructure
 
+module Array =
+    let insert v i (l : 'a array) =
+        let newArray = Array.zeroCreate (l.Length + 1)
+        let mutable newPointer = 0
+        l
+        |> Array.iteri(fun j y ->
+            if i = j then
+                newArray.[newPointer] <- v
+                newPointer <- newPointer + 1
+                newArray.[newPointer] <- y
+                newPointer <- newPointer + 1
+            else
+                newArray.[newPointer] <- y
+                newPointer <- newPointer + 1
+        )
+        newArray
+
+
+
 module Assert =
     open System
 
@@ -128,7 +147,7 @@ module Effect =
         match lines |> Array.tryFindIndex (fun line -> line.Contains "let gitRelease") with
         | None -> ()
         | Some startIdx ->
-            let mutable i = startIdx+1
+            let mutable i = startIdx + 1
             let mutable keepGoing = true
             while keepGoing && i < Array.length lines do
                 if lines.[i].StartsWith("let githubRelease") then
@@ -160,6 +179,18 @@ module Effect =
     let ``set environment variable`` name value (d : DirectoryInfo) =
         Environment.SetEnvironmentVariable(name, value)
 
+    let ``add change to CHANGELOG`` (d : DirectoryInfo) =
+        let changelog = Path.combine d.FullName "CHANGELOG.md"
+        let lines = File.ReadAllLines changelog
+        match lines |> Array.tryFindIndex (fun line -> line.Contains "## [Unreleased]") with
+        | None -> ()
+        | Some startIdx ->
+            let newLines =
+                lines
+                |> Array.insert "### Changed" (startIdx + 1)
+                |> Array.insert "- This is a test change from (@TheAngryByrd)" (startIdx + 2)
+            newLines |> File.writeNew changelog
+
     let ``setup for release tests`` (d : DirectoryInfo) =
         ``git init`` d
         ``git commit all`` "Initial commit" d
@@ -169,3 +200,4 @@ module Effect =
         // We don't want to actually release anything during integration tests!
         ``set environment variable`` "NUGET_KEY" "" d
         ``set environment variable`` "GITHUB_TOKEN" "" d
+        ``add change to CHANGELOG`` d