-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use BinaryDefense.FSharp.Analyzers.Hashing 0.2.2. Pinned Fantomas version to 3.2. #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntomas version to 3.2.
Getting build failure
|
Ah, I wonder if the |
TheAngryByrd
added a commit
that referenced
this pull request
May 25, 2021
## [0.26.4-beta001] - 2021-05-25 ### Changed - Update to use BinaryDefense.FSharp.Analyzers.Hashing 0.2.2 from [@enovales](https://github.com/enovales) - #238
TheAngryByrd
added a commit
that referenced
this pull request
May 25, 2021
## [0.26.4] - 2021-05-25 ### Changed - Update to use BinaryDefense.FSharp.Analyzers.Hashing 0.2.2 from [@enovales](https://github.com/enovales) - #238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This updates the
paket.dependencies
used by the template projects, to pull in BinaryDefense.FSharp.Analyzers.Hashing 0.2.2, and fsharp-analyzers 0.8.0, for compatibility with the latest F# compiler service, analyzer SDK, etc. Thepaket.lock
file for the templates was also updated, resulting in a number of other dependency updates.This also pins the version of Fantomas to 3.2 (previously unpinned), so it doesn't move when running
paket update
, until the template can be updated accordingly.Types of changes
Checklist
Further comments
I created library and console projects with the template locally, and confirmed that they build out of the box.