Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #262, closes #270 #271

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Closes #262, closes #270 #271

merged 6 commits into from
Jun 7, 2023

Conversation

nikoyak
Copy link
Contributor

@nikoyak nikoyak commented Jun 5, 2023 •
edited by TheAngryByrd
Loading

Proposed Changes

Almost line by line copying of the 'build' project and GitHub Actions from TheAngryByrd/IcedTasks repository. Similar changes have been made to the Content/Library template.

Types of changes

What types of changes does your code introduce to MiniScaffold?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Tests had to be corrected.

@TheAngryByrd
Copy link
Owner

Thank you so much for this! I'll start reviewing it later tonight.

@nikoyak
Copy link
Contributor Author

nikoyak commented Jun 6, 2023

Sorry I didn't test CI build. Fixed.

TheAngryByrd
TheAngryByrd requested changes Jun 6, 2023
View reviewed changes
Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

One thing I'd like to revert/change listed in the feedback.

Content/Library/build/Changelog.fs Show resolved Hide resolved
@nikoyak nikoyak force-pushed the buildsystem-from-icedtasks branch from cab9433 to ccab474 Compare June 6, 2023 21:32
@TheAngryByrd TheAngryByrd merged commit dec2527 into TheAngryByrd:master Jun 7, 2023
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha001
d35d529 
## [0.33.0-alpha001] - 2023-06-06

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha002
64a88e5 
## [0.33.0-alpha002] - 2023-06-06

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha003
9d654ef 
## [0.33.0-alpha003] - 2023-06-06

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
@nikoyak nikoyak deleted the buildsystem-from-icedtasks branch June 7, 2023 05:08
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha004
a667290 
## [0.33.0-alpha004] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha005
23658a0 
## [0.33.0-alpha005] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha006
93a7c91 
## [0.33.0-alpha006] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha007
b65e474 
## [0.33.0-alpha007] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha008
08003ca 
## [0.33.0-alpha008] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0-alpha009
4d1cdb4 
## [0.33.0-alpha009] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
TheAngryByrd added a commit that referenced this pull request Jun 7, 2023
@TheAngryByrd
Bump version to 0.33.0
972265c 
## [0.33.0] - 2023-06-07

### Changed
- [Update Dependencies](#267) from @TheAngryByrd
- [Numerous Build Tweaks](#269) from @TheAngryByrd
- [Updating Publishing and Use FSDocs for documentation](#271) from @nikoyak
This was referenced Jun 8, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace docsTool with fsdocs. Publish via CI
2 participants
@nikoyak @TheAngryByrd