Reduce file string allocations

TheAssemblyArmada · Feb 5, 2024 · 39e15bb · 39e15bb
1 parent 13c2fc0
commit 39e15bb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/game/common/system/file.cpp b/src/game/common/system/file.cpp
@@ -44,8 +44,18 @@ bool Decode_Buffered_File_Mode(int mode, int &buffer_size)
     }
     return false;
 }
+
+// Optimization to reduce string allocations.
+const Utf8String s_defaultFileName("<no file>");
+
 } // namespace Thyme
 
+File::File() : m_access(0), m_open(false), m_deleteOnClose(false)
+{
+    // Set_Name("<no file>");
+    m_name = Thyme::s_defaultFileName;
+}
+
 File::~File()
 {
     File::Close();
@@ -93,7 +103,8 @@ bool File::Open(const char *filename, int mode)
 void File::Close()
 {
     if (m_open) {
-        Set_Name("<no file>");
+        // Set_Name("<no file>");
+        m_name = Thyme::s_defaultFileName;
         m_open = false;
 
         if (m_deleteOnClose) {

diff --git a/src/game/common/system/file.h b/src/game/common/system/file.h
@@ -95,7 +95,7 @@ class File : public MemoryPoolObject
     void Delete_On_Close() { m_deleteOnClose = true; }
 
 protected:
-    File() : m_access(0), m_open(false), m_deleteOnClose(false) { Set_Name("<no file>"); }
+    File();
 
 protected:
     Utf8String m_name;