Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More W3DView work #1039

Merged
merged 1 commit into from
Jan 7, 2024
Merged

More W3DView work #1039

merged 1 commit into from
Jan 7, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Jan 7, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 590 lines in your changes are missing coverage. Please review.

Comparison is base (e91f48c) 2.71% compared to head (711fbad) 2.69%.

Files Patch % Lines
src/platform/w3dengine/client/w3dview.cpp 0.00% 583 Missing ⚠️
src/game/client/gameclient.cpp 0.00% 4 Missing ⚠️
src/game/client/gameclient.h 0.00% 2 Missing ⚠️
src/platform/w3dengine/client/w3dscene.h 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1039      +/-   ##
===========================================
- Coverage     2.71%    2.69%   -0.02%     
===========================================
  Files          919      919              
  Lines       103130   103723     +593     
  Branches     17484    17579      +95     
===========================================
  Hits          2797     2797              
- Misses       99929   100522     +593     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonwil
Copy link
Contributor Author

jonwil commented Jan 7, 2024

Played all the way through GLA01 with no observed glitches.

src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
@xezon
Copy link
Contributor

xezon commented Jan 7, 2024

Shellmap camera looks as usual.
USA01 camera sequences look as usual.
USA02 intro sequence looks as usual.
Skirmish camera works as usual. Camera rotation, zoom, scroll, reset controls work.
Replay camera works as usual.

@jonwil jonwil merged commit 24d413c into TheAssemblyArmada:develop Jan 7, 2024
7 checks passed
@jonwil jonwil deleted the view2 branch January 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants