Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix particle system crash #1055

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix particle system crash #1055

merged 1 commit into from
Jan 21, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Jan 21, 2024 •
edited by xezon
Loading

@jonwil jonwil requested a review from xezon January 21, 2024 11:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (18f7233) 2.65% compared to head (0912ff3) 2.65%.

Files Patch % Lines
...lient/system/particlesystem/particlesysmanager.cpp 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
- Coverage     2.65%    2.65%   -0.01%     
===========================================
  Files          928      928              
  Lines       105319   105321       +2     
  Branches     17877    17877              
===========================================
  Hits          2799     2799              
- Misses      102116   102118       +2     
  Partials       404      404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xezon
xezon approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested USA04 Intro 3 times. No crashes.

@jonwil jonwil merged commit 937f58e into TheAssemblyArmada:develop Jan 21, 2024
7 checks passed
@jonwil jonwil deleted the particle branch January 21, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in ParticleSystemManager::Update, corrupted stack
3 participants
@jonwil @codecov-commenter @xezon