Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some stuff for GameClient #1072

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Feb 2, 2024

No description provided.

@jonwil jonwil requested a review from xezon February 2, 2024 11:52
@jonwil jonwil force-pushed the gameclient branch 3 times, most recently from 89e2c4d to 1f63545 Compare February 2, 2024 12:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 668 lines in your changes missing coverage. Please review.

Project coverage is 2.58%. Comparing base (2243feb) to head (e642a6e).
Report is 49 commits behind head on develop.

Files with missing lines Patch % Lines
src/game/client/gameclient.cpp 0.00% 251 Missing ⚠️
src/game/client/languagefilter.cpp 0.00% 89 Missing ⚠️
src/game/client/gui/shell/shell.cpp 0.00% 71 Missing ⚠️
src/platform/w3dengine/client/w3dgameclient.cpp 0.00% 46 Missing ⚠️
src/game/client/gui/imemanager.cpp 0.00% 40 Missing ⚠️
src/game/client/messagestream/lookatxlat.cpp 0.00% 26 Missing ⚠️
src/game/client/gui/shell/shellmenuscheme.cpp 0.00% 23 Missing ⚠️
src/game/client/eva.cpp 0.00% 20 Missing ⚠️
src/game/client/system/campaignmanager.cpp 0.00% 20 Missing ⚠️
src/game/client/gui/headertemplate.cpp 0.00% 18 Missing ⚠️
... and 20 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
- Coverage     2.59%    2.58%   -0.02%     
===========================================
  Files          930      941      +11     
  Lines       107792   108476     +684     
  Branches     18382    18500     +118     
===========================================
  Hits          2799     2799              
- Misses      104589   105273     +684     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch.

src/game/client/eva.cpp Outdated Show resolved Hide resolved
src/game/client/eva.cpp Show resolved Hide resolved
src/game/client/eva.h Outdated Show resolved Hide resolved
src/game/client/gui/headertemplate.h Outdated Show resolved Hide resolved
src/game/client/gui/headertemplate.h Show resolved Hide resolved
src/game/client/eva.cpp Show resolved Hide resolved
src/game/client/gui/imemanager.cpp Show resolved Hide resolved
src/game/client/gui/shell/shell.h Show resolved Hide resolved
src/game/client/messagestream/metaevent.cpp Show resolved Hide resolved
src/game/client/messagestream/metaevent.cpp Show resolved Hide resolved
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next batch.

src/game/client/languagefilter.cpp Show resolved Hide resolved
src/game/client/languagefilter.cpp Outdated Show resolved Hide resolved
src/game/client/languagefilter.cpp Outdated Show resolved Hide resolved
src/game/client/languagefilter.cpp Show resolved Hide resolved
src/game/client/languagefilter.cpp Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Show resolved Hide resolved
src/game/client/gameclient.cpp Show resolved Hide resolved
src/game/client/gameclient.cpp Show resolved Hide resolved
src/game/client/gameclient.cpp Show resolved Hide resolved
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game crashes when changing resolution in options menu, or just shutting down the game.

 	0e59d45c()	Unknown
 	[Frames below may be incorrect and/or missing]	Unknown
>	[Inline Frame] thyme.dll!WindowLayout::Run_Shutdown(void *) Line 77	C++
 	thyme.dll!Shell::Pop_Immediate() Line 164	C++
 	thyme.dll!Shell::~Shell() Line 51	C++
 	thyme.dll!Shell::`scalar deleting destructor'(unsigned int)	C++
 	game.dat!0046b419()	Unknown
 	game.dat!00468922()	Unknown
 	thyme.dll!GameWindowManager::Win_Send_System_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 451	C++
 	thyme.dll!Pass_Messages_To_Parent_System(GameWindow * window, unsigned int msg, unsigned int data_1, unsigned int data_2) Line 209	C++
 	thyme.dll!GameWindowManager::Win_Send_System_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 451	C++
 	game.dat!005abff5()	Unknown
 	thyme.dll!GameWindowManager::Win_Send_Input_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 464	C++

Exception thrown at 0x0E59D45C in game.dat: 0xC0000005: Access violation reading location 0xFFFFFFFF.

@jonwil jonwil force-pushed the gameclient branch 2 times, most recently from aed5e40 to 9e7c745 Compare February 3, 2024 11:59
@jonwil jonwil requested a review from xezon February 3, 2024 11:59
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text field input does not work. Introduced by this change.

Can be tested in Network lobby.

shot_20240203_130152_1

@xezon
Copy link
Contributor

xezon commented Feb 3, 2024

WindowLayout::Run_Shutdown crash is fixed.

@xezon
Copy link
Contributor

xezon commented Feb 3, 2024

Terrain scorch works
Time of day, night, snow, works
Texture lod works
Texts, fonts look as usual
Team color works
Campaign works
View bookmarks work
Camera controls work
Hotkeys work
Shell Menu works and looks as usual
Diplomacy screen works

RayEffects is untested
IMECandidateWindow is untested

@xezon
Copy link
Contributor

xezon commented Feb 3, 2024

Eva works

@xezon
Copy link
Contributor

xezon commented Feb 3, 2024

Text field input is fixed.
Profanity filter works.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further new problems found.

@jonwil jonwil merged commit 9cec511 into TheAssemblyArmada:develop Feb 3, 2024
7 checks passed
@jonwil jonwil deleted the gameclient branch February 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants