-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some stuff for GameClient #1072
Conversation
89e2c4d
to
1f63545
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1072 +/- ##
===========================================
- Coverage 2.59% 2.58% -0.02%
===========================================
Files 930 941 +11
Lines 107792 108476 +684
Branches 18382 18500 +118
===========================================
Hits 2799 2799
- Misses 104589 105273 +684
Partials 404 404 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next batch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Game crashes when changing resolution in options menu, or just shutting down the game.
0e59d45c() Unknown
[Frames below may be incorrect and/or missing] Unknown
> [Inline Frame] thyme.dll!WindowLayout::Run_Shutdown(void *) Line 77 C++
thyme.dll!Shell::Pop_Immediate() Line 164 C++
thyme.dll!Shell::~Shell() Line 51 C++
thyme.dll!Shell::`scalar deleting destructor'(unsigned int) C++
game.dat!0046b419() Unknown
game.dat!00468922() Unknown
thyme.dll!GameWindowManager::Win_Send_System_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 451 C++
thyme.dll!Pass_Messages_To_Parent_System(GameWindow * window, unsigned int msg, unsigned int data_1, unsigned int data_2) Line 209 C++
thyme.dll!GameWindowManager::Win_Send_System_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 451 C++
game.dat!005abff5() Unknown
thyme.dll!GameWindowManager::Win_Send_Input_Msg(GameWindow * window, unsigned int msg, unsigned int data1, unsigned int data2) Line 464 C++
Exception thrown at 0x0E59D45C in game.dat: 0xC0000005: Access violation reading location 0xFFFFFFFF.
aed5e40
to
9e7c745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WindowLayout::Run_Shutdown crash is fixed. |
Terrain scorch works RayEffects is untested |
Eva works |
Text field input is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No further new problems found.
No description provided.