Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more GameClient stuff #1080

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Feb 4, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 364 lines in your changes are missing coverage. Please review.

Comparison is base (9cec511) 2.58% compared to head (a33e8f9) 2.57%.

Files Patch % Lines
src/game/client/gameclient.cpp 0.00% 173 Missing ⚠️
src/game/client/gui/imemanager.cpp 0.00% 48 Missing ⚠️
src/game/client/system/campaignmanager.cpp 0.00% 44 Missing ⚠️
src/game/client/gui/shell/shellmenuscheme.cpp 0.00% 34 Missing ⚠️
src/game/client/eva.cpp 0.00% 28 Missing ⚠️
src/game/client/gui/headertemplate.cpp 0.00% 18 Missing ⚠️
src/platform/w3dengine/client/w3dscene.cpp 0.00% 6 Missing ⚠️
src/game/client/videoplayer/videoplayer.cpp 0.00% 5 Missing ⚠️
src/game/client/ingameui.cpp 0.00% 1 Missing ⚠️
.../game/client/system/particlesystem/particlesys.cpp 0.00% 1 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1080      +/-   ##
===========================================
- Coverage     2.58%    2.57%   -0.01%     
===========================================
  Files          941      943       +2     
  Lines       108476   108838     +362     
  Branches     18500    18565      +65     
===========================================
  Hits          2799     2799              
- Misses      105273   105635     +362     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/game/client/gui/shell/shellmenuscheme.cpp Show resolved Hide resolved
src/game/client/gui/headertemplate.cpp Outdated Show resolved Hide resolved
src/game/client/gui/imemanager.cpp Show resolved Hide resolved
src/game/client/gui/imemanager.cpp Outdated Show resolved Hide resolved
src/game/client/gui/imemanager.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After EA Logo video, there is no Sizzle video, game just stays black.

shot_20240204_194658_1

@jonwil
Copy link
Contributor Author

jonwil commented Feb 4, 2024

Missing video fixed.

xezon

This comment was marked as off-topic.

src/game/client/gameclient.cpp Outdated Show resolved Hide resolved
src/game/client/gui/imemanager.cpp Outdated Show resolved Hide resolved
@xezon
Copy link
Contributor

xezon commented Feb 4, 2024

EA Logo video works
Sizzle video works
Shell menu and map works
Keyboard works
Eva works
Mouse works
Drawables shrouded update works
String display works
Terrain works
InGameUI works
Header Templates work
Campaign works
Challenge works
Online menus work

IME Manager not tested

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell Map looks as usual.
No new crashes encountered.

@jonwil jonwil merged commit 7e77fc8 into TheAssemblyArmada:develop Feb 4, 2024
7 checks passed
@jonwil jonwil deleted the gameclient2 branch February 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants