Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more UI code #1089

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Implement more UI code #1089

merged 1 commit into from
Feb 8, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Feb 7, 2024

@jonwil jonwil requested a review from xezon February 7, 2024 07:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 1055 lines in your changes are missing coverage. Please review.

Comparison is base (1260d86) 2.55% compared to head (d1e9fc9) 2.53%.

Files Patch % Lines
src/game/client/gui/gadget/gadgetlistbox.cpp 0.00% 424 Missing ⚠️
src/game/client/gui/gadget/gadgetpushbutton.cpp 0.00% 199 Missing ⚠️
src/game/client/gui/gadget/gadgettabcontrol.cpp 0.00% 136 Missing ⚠️
src/game/client/gui/gadget/gadgettextentry.cpp 0.00% 110 Missing ⚠️
src/game/client/gui/gadget/gadgetcombobox.cpp 0.00% 95 Missing ⚠️
src/game/client/gui/gadget/gadgetcheckbox.cpp 0.00% 73 Missing ⚠️
src/game/client/gui/gadget/gadgetradiobutton.cpp 0.00% 17 Missing ⚠️
src/game/common/system/unicodestring.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1089      +/-   ##
===========================================
- Coverage     2.55%    2.53%   -0.03%     
===========================================
  Files          949      949              
  Lines       109418   110292     +874     
  Branches     18667    18881     +214     
===========================================
  Hits          2799     2799              
- Misses      106215   107089     +874     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch

src/game/client/gui/gadget/gadgetcheckbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetcheckbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetcheckbox.cpp Show resolved Hide resolved
src/game/client/gui/gadget/gadgetcheckbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetcheckbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetpushbutton.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetpushbutton.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetpushbutton.cpp Outdated Show resolved Hide resolved
@jonwil jonwil force-pushed the gui branch 2 times, most recently from 961e0b7 to a06a416 Compare February 7, 2024 19:38
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second batch.

src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
src/game/client/gui/gadget/gadgetlistbox.cpp Outdated Show resolved Hide resolved
xezon

This comment was marked as off-topic.

@xezon
Copy link
Contributor

xezon commented Feb 8, 2024

Check Box works
Combo Box works
Combo List works
Static Text works
Progress Bar works
Button works
Tab Control not tested, what is this?
Text Entry works

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No crashes. UI gadgets work in principle.

@jonwil jonwil merged commit fc578f0 into TheAssemblyArmada:develop Feb 8, 2024
7 checks passed
@jonwil jonwil deleted the gui branch February 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace key does not remove text in text fields
3 participants