Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memset size in IMEManager::Update_Candidate_List #1150

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Sep 6, 2024

Looks like memset had wrong size.

@xezon xezon added the fixing label Sep 6, 2024
@tomsons26
Copy link
Contributor

@xezon
Copy link
Contributor Author

xezon commented Sep 9, 2024

@tomsons26
I still think it is wrong in Thyme. We memset too little of the allocated array. It should be sizeof struct * count, no?

Edit: Ah no.

It should be CANDIDATELIST *list = new CANDIDATELIST[count]; instead of CANDIDATELIST *list = new CANDIDATELIST[size];

@xezon
Copy link
Contributor Author

xezon commented Sep 9, 2024

Let's try this: #1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants