Fix errors in Weapon::Get_Percent_Ready_To_Fire

[bobtista]

• Fixes Assert in Weapon::Get_Percent_Ready_To_Fire() is hit after using clear mines ability #916

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 2.53%. Comparing base (a8f8d8b) to head (9e13820).

Files	Patch %	Lines
src/game/logic/object/weapon.cpp	0.00%	10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #928   +/-   ##
========================================
  Coverage     2.53%    2.53%           
========================================
  Files          949      949           
  Lines       110171   110171           
  Branches     18880    18880           
========================================
  Hits          2797     2797           
  Misses      106972   106972           
  Partials       402      402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonwil]

Having reviewed the original code, the correct fix is to rename time_left to total_time and total_time to time_left.
So
unsigned int time_left = next_shot - m_whenLastReloadStarted;
becomes
unsigned int total_time = next_shot - m_whenLastReloadStarted;
and
unsigned int total_time = next_shot - m_whenLastReloadStarted;
becomes
unsigned int time_left = next_shot - m_whenLastReloadStarted;

and the other uses of both variables get swapped as well.

And no we should not use the getter in this case.

[xezon]

Does change fix #916 confirmed?

Does it perhaps also fix #888?

[jonwil]

Verified that the change in this PR is correct. Approved.

[xezon]

I will check later if this fixes the bugs.

[xezon]

• Fixes Assert in Weapon::Get_Percent_Ready_To_Fire() is hit after using clear mines ability #916
• Does not fix GLA Bomb Truck can no longer attack #888