Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Conversion from *AcqKnowledge* to BIDS #318

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Oct 30, 2023

This PR concludes the conversion from AcqKnowledge into BIDS:

  • Sessions 1-24 have been added to the datalad dataset on curnagl with physio. Exceptions
  • Update SOPs accordingly, including a Jupyter Notebook showing the conversion.

Relates-to: #120.

@oesteban oesteban requested a review from esavary November 1, 2023 15:19
@oesteban oesteban marked this pull request as ready for review November 1, 2023 15:19
Comment on lines +75 to +80
# - mkpdfs:
# company: Lausanne University Hospital (CHUV)
# author: The Axon Lab
# toc_title: Table of Contents
# design: design/report.css
# output_path: pdf/documentation.pdf
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me sneak this in, otherwise development is super slow

@oesteban oesteban requested a review from acionca November 1, 2023 15:24
@oesteban
Copy link
Collaborator Author

oesteban commented Nov 1, 2023

Copy link
Collaborator

@acionca acionca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick check for now, here are some suggestions:

  • I would suggest renaming the notebook with underscores instead of spaces.

  • Also, I tried to mkdocs serve and got the error below, could it be a missing dependancy ?

jinja2.exceptions.UndefinedError: 'mermaid_js' is undefined

EDIT: Looks like there's a known bug with mkdocs-jupyter 0.24.3+ (see danielfrg/mkdocs-jupyter#176) – I would suggest to force using 0.24.2 which worked for me.

  • On my local mkdocs serve, the latex math rendering with $ did not render properly (e.g., $t=0$)

mkdocs.yml Outdated Show resolved Hide resolved
docs/data-management/physio-to-bids.ipynb Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
oesteban and others added 2 commits November 1, 2023 23:16
Co-authored-by: Alexandre Cionca <43985138+acionca@users.noreply.github.com>
Co-authored-by: Alexandre Cionca <43985138+acionca@users.noreply.github.com>
@oesteban
Copy link
Collaborator Author

oesteban commented Nov 1, 2023

  • Also, I tried to mkdocs serve and got the error below, could it be a missing dependancy ?
jinja2.exceptions.UndefinedError: 'mermaid_js' is undefined

I think you need material >= 8.2.0 (https://squidfunk.github.io/mkdocs-material/changelog/#8.2.0)

  • On my local mkdocs serve, the latex math rendering with $ did not render properly (e.g., $t=0$)

Let's open an issue for this somewhere else

@oesteban oesteban merged commit 98c68d7 into mkdocs Nov 1, 2023
1 check passed
@oesteban oesteban deleted the enh/physio2bids branch November 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants