Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bevy run #120
Bevy run #120
Changes from 3 commits
7543333
35d6a28
0dbe6fd
07ba6bc
46e8c09
2ceaac2
dd111a9
ececb81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had situations where
https
onlocalhost
was necessary for development of a project. Do you think it would be nice to have the option here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, setting up HTTPS is not worth it for a development server such as this. The primary purpose of TLS is to secure communication across untrusted networks, but
127.0.0.1
is completely local, so there's no network to worry about.bevy run web
is not meant for production. In those cases you build everything ahead of time and serve it with something like Nginx, which implements TLS already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to create a valid certificate for
localhost
to enable HTTPS?I'd say that when we need it, we can create a follow-up issue to enable that functionality :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, assuming openssl or the like is installed. We can leave it to the user to create their own self signed cert. It's a common step for web developers and is usually its own step outside of other tooling.