Bug fixing and chores related to linting #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
A-Linter
|
CI failure will be fixed by #120, once it is merged. |
bas-ie
reviewed
Sep 30, 2024
BD103
force-pushed
the
lint-cli-improvements
branch
from
c53b880 to
6a4f3e3
Compare
BD103
force-pushed
the
lint-cli-improvements
branch
from
6a4f3e3 to
4639388
Compare
BD103
changed the title
--cfg bevy_lint in bevy_lint
bas-ie
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles a few issues with how
bevy_lintfunctions.First, it closes #117 by passing
--cfg bevy_linttorustcwhenbevy_lintis called. This allows code to conditionally configure lints (e.g.#[cfg_attr(bevy_lint, allow(bevy::lint))]).Secondly, it fixes #118 by specifying the nightly version when calling
cargo check. I originally hardcoded this version, but after a comment from @richchurcher I adjusted it to take the version fromrust-toolchain.toml. (It specifically uses a build script to parserust-toolchain.tomlusingtoml_edit, then passes it to the code using an environmental variable.)Thirdly, I removed other hard-coded references to the specifically nightly channel in
README.mdandci.yml. (In CI I specifically used Taplo to parse the version, similar tojq.)Finally, I added a bit more metadata to
Cargo.tomlthat will be used by https://crates.io once it is published.