Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS for rustdoc alerts #161

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Add CSS for rustdoc alerts #161

merged 4 commits into from
Nov 6, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Oct 21, 2024

Closes #158, extracted from #152, will be used in #109.

This adds pretty alerts in rustdoc for bevy_lint that will be used in #109 when writing bevy_lint's user documentation.

alerts in light mode alerts in dark mode alerts in dark mode, with the ayu theme

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Docs An improvement in documentation labels Oct 21, 2024
mockersf
mockersf reviewed Oct 21, 2024
View reviewed changes
bevy_lint/src/lib.rs Outdated Show resolved Hide resolved
@BD103 BD103 mentioned this pull request Oct 23, 2024
Closed
@BD103 BD103 requested a review from mockersf October 23, 2024 14:50
@BD103 BD103 mentioned this pull request Oct 31, 2024
Merged
BD103 added a commit that referenced this pull request Oct 31, 2024
@BD103
Clarify release.md and add compatibility table (#166)
ff50477 
Closes #165, begins tackling #109.

This PR makes some small improvements to `release.md` based on @MrGVSV's
comments. It also adds a minimal `README.md` with the compatibility
table.

This `README.md` is not in its the final form, and it will be
significantly improved once #109 and #161 are done.
@BD103 BD103 enabled auto-merge (squash) November 6, 2024 12:56
@BD103 BD103 merged commit 2480d60 into main Nov 6, 2024
8 checks passed
@BD103 BD103 deleted the rustdoc-alerts branch November 6, 2024 13:04
@BD103 BD103 mentioned this pull request Nov 9, 2024
Merged
BD103 added a commit that referenced this pull request Nov 20, 2024
@BD103
Use cargo doc-lints when building Github Pages (#173)
458e416 
This is a change I forgot to add in #161. It fixes the alerts so instead
of looking like:


![image](https://github.com/user-attachments/assets/fcb68295-07b6-4173-94fc-dea13be18d1e)

They look like:


![image](https://github.com/user-attachments/assets/04983c8c-5284-4b14-8b68-af81fba813e5)

While this fix is not necessary for v0.1.0's release, I would like to
get it in sooner rather than later! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimJentzsch TimJentzsch TimJentzsch approved these changes

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Linter Related to the linter and custom lints C-Docs An improvement in documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom CSS for pretty rustdoc alerts
3 participants
@BD103 @mockersf @TimJentzsch