Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI test harness #32

Closed
wants to merge 3 commits into from
Closed

Add UI test harness #32

wants to merge 3 commits into from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Sep 3, 2024

Closes #31.

This adds ui_test as a dev-dependency of bevy_lint, so we can test diagnostics.

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Testing A change to the tests labels Sep 3, 2024
@BD103
Copy link
Member Author

BD103 commented Sep 4, 2024

I've been having some issues getting this setup. (Mainly since the driver is not feature-complete.) I may put this on hold for the time being.

@janhohenheim
Copy link
Member

janhohenheim commented Sep 5, 2024

@BD103 completely fine to leave this out for now imo :) Out of curiosity, what issues are you running into?

@BD103
Copy link
Member Author

BD103 commented Sep 6, 2024

@BD103 completely fine to leave this out for now imo :) Out of curiosity, what issues are you running into?

I'm having issues getting bevy_link_driver to link to librustc_driver.so. I may need to switch to rpaths for the time being.

@BD103
Copy link
Member Author

BD103 commented Sep 13, 2024

Closing for now. I'll return to this in a few weeks, once I've had some time to mull it over.

@BD103 BD103 closed this Sep 13, 2024
@BD103 BD103 deleted the ui-tests branch September 16, 2024 18:38
@BD103
Copy link
Member Author

BD103 commented Sep 16, 2024

Looking back at this, it may be worth trying to use ui_test's Cargo integration instead of using rustc directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints C-Testing A change to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup UI tests for lints
2 participants