-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint: bevy::insert_event_resource
#86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rustfmt` doesn't format the lint modules because it can't find `mod name;` syntax for them. And honestly? This is fine until it becomes incredibly cumbersome.
This puts it all together, so you're less likely to forget to register the pass.
This reverts commit f862506.
BD103
added
A-Linter
Related to the linter and custom lints
C-Feature
Make something new possible
S-Blocked
This cannot move forward until something else changes
labels
Sep 18, 2024
BD103
removed
the
S-Blocked
This cannot move forward until something else changes
label
Sep 18, 2024
Co-authored-by: Christopher Biscardi <chris@christopherbiscardi.com>
janhohenheim
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is robust to my testing. Treat all of my comments on the PR as very minor opinions, I'm fine either way :)
I'm going to let this sit for a few hours in case anyone has some last-minute feedback. After that, it's getting merged! |
alice-i-cecile
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased off of #84, so that will have to be merged first. Closes #40.
This checks for cases where
App::init_resource::<Events<T>>()
and friends are used instead ofApp::add_event::<T>()
. I used the following code to test it:Put it in
bevy_lint/examples/lint_test.rs
,cd
intobevy_lint
, then runcargo build && cargo run -- --example lint_test
. The output should look like this: