Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect redstone connection masks #149

Merged
merged 7 commits into from
Nov 3, 2023
Merged

fix incorrect redstone connection masks #149

merged 7 commits into from
Nov 3, 2023

Conversation

MrTJP
Copy link
Member

@MrTJP MrTJP commented Jun 24, 2023

  • Fixed masks from RedstoneConnectorBlock not being used
  • Remove legacy logic overriding canConnectRedstone for side 0. All faces are now correctly handled by it
  • Add a client-side check in TickScheduler#loadRandomTick. This prevents client-side chuck corruption if world is loaded with any part that uses the TickScheduler (RedstoneTorchPart for example).
  • Add custom placement state logic for both button and lever parts rather than rely on the block's logic. Takes care of more invalid placement edge cases
  • Properly calculate Redstone connection masks for vanilla blocks rather than using 0x1F. This stops connections from behaving differently if the block is vanilla or a converted part. Plus, this fixes comparators/dust from being connected from top face
  • Register a bunch of new decorative 1.18 blocks as micro materials:
    • All Deepslate ores
    • Azalea leaves variants
    • Soul soil
    • Basalt variants
    • Lit redstone lamp
    • Purpur variants
    • Dirt path
    • Warped and crimson variants of Nylium, wart, planks, etc
    • Blackstone varients
    • Netherite, quartz, and nether brick variants
    • Honey, honeycomb
    • Lodestone
    • Blackstone variants
    • Crying obsidian
    • Copper block variants
    • Tuff
    • Calcite
    • Tinted glass
  • Add MultipartPlaceContext which improves placement context and also has native support for offset placement. It is also a subclass of BlockPlaceContext and is fully compatible with vanilla placement logic. All existing methods accepting a generic UseOnContext are kept and deprecated. Existing logic on those methods still work as before.

@MrTJP MrTJP mentioned this pull request Jul 10, 2023
@covers1624 covers1624 merged commit ee4de53 into master Nov 3, 2023
2 checks passed
@MrTJP MrTJP deleted the patch-0624 branch November 3, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants