Revert "Attempt to release ByteBufs."

[FoxMcloud5655]

This breaks Draconic Evolution and potentially any other mod that relies on PacketCustom.java.

[FoxMcloud5655]

It may be worth trying to implement this in a different way, but for now, leaving out the line of code makes DE work again. I don't know enough about this mod to help otherwise!

[covers1624]

'makes DE work again' explain, does it crash? whats wrong?

[FoxMcloud5655]

It causes clients connecting to a single-player world hosted locally to become disconnected upon receiving a packet based on PacketCustom.

[covers1624]

Please provide logs.

[FoxMcloud5655]

Alrighty. Don't have access to my computer currently, but I will get them first thing in the morning.

[FoxMcloud5655]

In this test case, I was using an Energy Core from Draconic Evolution to test CCL. The client is disconnected upon receiving the packet, and the server throws the same error many times:

[09:22:02] [Netty Server IO #3/ERROR] [FML]: NetworkDispatcher exception
io.netty.util.IllegalReferenceCountException: refCnt: 0
	at io.netty.buffer.AbstractByteBuf.ensureAccessible(AbstractByteBuf.java:1408) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.buffer.UnpooledHeapByteBuf.array(UnpooledHeapByteBuf.java:154) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at net.minecraft.network.PacketBuffer.array(PacketBuffer.java:1264) ~[gy.class:?]
	at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.toS3FPackets(FMLProxyPacket.java:151) ~[FMLProxyPacket.class:?]
	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.write(NetworkDispatcher.java:537) ~[NetworkDispatcher.class:?]
	at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:801) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:814) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:794) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:831) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1032) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:296) ~[netty-all-4.1.9.Final.jar:4.1.9.Final]
	at net.minecraft.network.NetworkManager$4.run(NetworkManager.java:245) [gw$4.class:?]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:403) [netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:442) [netty-all-4.1.9.Final.jar:4.1.9.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) [netty-all-4.1.9.Final.jar:4.1.9.Final]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]

It was hard to trace down, but I finally managed to find this one line of code. Removing it fixed the problem, and I don't know how to redesign the code to release the packet safely, as I don't know much about networking.

[calebjway]

Is there anyway I could implement this before the next update? Its making it hard to play a LAN game with my friends.

[FoxMcloud5655]

Just downgrade to the previous version. If you have a mod that depends on the latest version, you can compile it locally from my fork. Just remember to change the build number to something high like '9999', both so you know it's unofficial and so mods see it as a higher version than the one they're looking for.

[calebjway]

Have never done a custom compile before for a mod like this. Unfortunately the modpack I am using requires the newest version so I guess I am waiting for now. Thanks for the help.

[covers1624]

New build will be pushed to curse immediately.