Assorted bug fixes #152
Open
Assorted bug fixes #152
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just need to reoslve the conflicts, but looks mostly good. thanks |
These are required for the scripts to execute correctly on Windows.
Required for Windows which does not have the /var/lock directory.
config has no attribute loader, so attempting to create previews failed before this change.
The later fixes a bug as the rest of the class assumes sample_frames is a list. The former is currently dead code.
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of issues discovered when setting up the repository. Each commit is independent and should describe the bug/reason for the fix.
If preferred I am happy to split this into individual pull requests.