-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add severity filter to b:growl and b:messages #758
Comments
Or maybe add |
+1 for offering a PR! Limiting the growl to certain severities makes a lot of sense to me. I just wonder what a good API might look like. Chances are people won't agree which messages to show via |
I've submitted a pull request for this issue: #784 If it's accepted I could also update the showcase, or is it common practice to change both at once? |
In theory, it's common practice to update the showcase and the core library simultaneously. In practice, I'm happy with everything we get. Most people forget to send us a PR for the showcase :). |
OK. I'll update the showcase as well. |
@stephanrauh See TheCoder4eu/BootsFacesWeb#44 Note: there still is a TODO for the since version. |
Hi, this has been released in version 1.1.2. This issue can be closed ;-) |
Good point. Thanks for the hint! |
I love the
b:growl
component to show info messages. When it comes to showing error messages the growl sucks. Errors should be shown until the user dismisses them. You could do that usingb:messages
component... but there an info message like "Your data has been stored" seems out of place to me. Messages like that should disappear after a short while (like in the growl).I was checking out the Bootstrap Notify code to check if it was possible to have "sticky" messages, but it is not.
So I was kind of thinking if it would be a good idea to have an
ignoreSeverity
attribute on the growl and anincludeSeverity
attribute on messages. That way you could for example show all info messages in a growl and all warn, error and fatal messages in the messages component.Does this make any sense to you?
The text was updated successfully, but these errors were encountered: