Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add severity filter to b:growl and b:messages #758

Closed
jepsar opened this issue May 3, 2017 · 8 comments
Closed

Add severity filter to b:growl and b:messages #758

jepsar opened this issue May 3, 2017 · 8 comments
Milestone

Comments

@jepsar
Copy link
Contributor

jepsar commented May 3, 2017

I love the b:growl component to show info messages. When it comes to showing error messages the growl sucks. Errors should be shown until the user dismisses them. You could do that using b:messages component... but there an info message like "Your data has been stored" seems out of place to me. Messages like that should disappear after a short while (like in the growl).

I was checking out the Bootstrap Notify code to check if it was possible to have "sticky" messages, but it is not.

So I was kind of thinking if it would be a good idea to have an ignoreSeverity attribute on the growl and an includeSeverity attribute on messages. That way you could for example show all info messages in a growl and all warn, error and fatal messages in the messages component.

Does this make any sense to you?

@jepsar
Copy link
Contributor Author

jepsar commented May 9, 2017

Or maybe add severity to both (same as the PrimeFaces growl). Let me see if I can provide a pull request for this.

@stephanrauh
Copy link
Collaborator

+1 for offering a PR!

Limiting the growl to certain severities makes a lot of sense to me. I just wonder what a good API might look like. Chances are people won't agree which messages to show via b:growl and which via b:message. Therefore, I'd like to see an API that's both as flexible as possible and as simple as possible at the same time.

@jepsar
Copy link
Contributor Author

jepsar commented May 16, 2017

I've submitted a pull request for this issue: #784

If it's accepted I could also update the showcase, or is it common practice to change both at once?

@jepsar jepsar changed the title Possible improvement on b:growl and b:messages Add severity filter to b:growl and b:messages May 16, 2017
@stephanrauh
Copy link
Collaborator

In theory, it's common practice to update the showcase and the core library simultaneously. In practice, I'm happy with everything we get. Most people forget to send us a PR for the showcase :).

@jepsar
Copy link
Contributor Author

jepsar commented May 19, 2017

OK. I'll update the showcase as well.

@jepsar
Copy link
Contributor Author

jepsar commented May 20, 2017

@stephanrauh See TheCoder4eu/BootsFacesWeb#44

Note: there still is a TODO for the since version.

@jepsar
Copy link
Contributor Author

jepsar commented Aug 10, 2017

Hi, this has been released in version 1.1.2. This issue can be closed ;-)

@stephanrauh
Copy link
Collaborator

Good point. Thanks for the hint!

@stephanrauh stephanrauh added this to the v1.1.2 milestone Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants