Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add severity filter to b:growl and b:messages #784

Merged
merged 5 commits into from
May 19, 2017
Merged

Add severity filter to b:growl and b:messages #784

merged 5 commits into from
May 19, 2017

Conversation

jepsar
Copy link
Contributor

@jepsar jepsar commented May 15, 2017

I've opted for a serverity attribute on growl and messages:

<attribute>
  <description><![CDATA[Comma separated list of lower case severity names of which messages should be rendered in this component. Allowed severity names "info", "warn", "error", "fatal". Default value: "info,warn,error,fatal" (all severities).]]></description>
  <name>severity</name>
  <required>false</required>
  <type>java.lang.String</type>
</attribute>

This makes migrating from PrimeFaces easy.

@jepsar jepsar changed the title Improvement on b:growl and b:messages (fixing #758) Add severity filter to b:growl and b:messages May 16, 2017
@stephanrauh
Copy link
Collaborator

Thanks! You've even thought about adding the attribute to the *.jsfdsl file. Awesome!

Currently, we're a bit busy, so it may take some until we evaluate and merge (or - albeit unlikely - reject) your PR. Please stay tuned!

@stephanrauh stephanrauh merged commit faba3b0 into TheCoder4eu:master May 19, 2017
@stephanrauh stephanrauh added this to the v1.1.2 milestone May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants