BlockUI always enabled just by importing the library

[ggam]

Manually importing the BlockUI library enables it for AJAX requests even with it being disabled on the web.xml. BootsFaces AJAX API checks for the presence of the $.blockUI and if it's present and not null, it automatically blocks and unblocks the screen:

BootsFaces-OSP/gradleResources/staticResources/js/bsf.js

Line 39 in 5bdbf22

if ($.blockUI && $.blockUI != null) {

Since BlockUI cannot be disabled on a per request basis (like PrimeFaces does with the global attribute), I imported the library and disabled it on web.xml. But BootsFaces doesn't do the check on the client side.

I propose two changes here:

• [bug]: importing the library should not automatically enable it
• [feature]: a new way to disable BlockUI for a specific component/event (like PrimeFaces).

The workaround I've used for now is to rename the variables on my imported JS file, downloaded from the author's website.

[stephanrauh]

I guess it's easy to implement the check of the web.xml setting. If I'm not mistaken, you've already done similar things. If you want to submit the PR yourself, go ahead!

[ggam]

I guess just adding a EL expression to the JS file should work, no? Something like: if($.BlockUI != null && #{blockUIEnabled}) { // ... } The resource mechanism should interpret it. Would that be enough? I'l take a look and try to provide a PR when I find some time.

…

On Mon, May 22, 2017 at 10:50 PM, Stephan Rauh ***@***.***> wrote: I guess it's easy to implement the check of the web.xml setting. If I'm not mistaken, you've already done similar things. If you want to submit the PR yourself, go ahead! — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#790 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACAucHI2A47CLU6YVr8aqYlslbMvqmVFks5r8fUTgaJpZM4NiYWO> .

[chongma]

slightly related: i was doing pagespeed insights https://developers.google.com/speed/pagespeed/insights/ the other day and it said that the BlockUI javascript file was not minified. does BootsFaces use the minified version?

[stephanrauh]

Actually, there's no official minified version of BlockUI. I minified it manually.

[stephanrauh]

We've implemented this feature long ago. I've just added the documentation, so we can close the ticket.