#878 fix a diffrent between firefox and internet explorer #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-apzumi
reviewed
Jan 21, 2020
| try { | ||
| int oldIndex = getRowIndex(); | ||
| // after https://datatables.net/reference/event/deselect#Description indexes would be an array | ||
| // firefox und chrome do not send a array, only the old IE send a array to the server | ||
| indexes = indexes.replace("[", "").replace("]", "").trim(); | ||
| int index = Integer.valueOf(indexes); |
There was a problem hiding this comment.
should not it be an Integer type? it can be null I think if the indexes is not provided
kd-apzumi
reviewed
Jan 21, 2020
| int index = Integer.valueOf(indexes); | ||
| setRowIndex(index); | ||
| super.queueEvent(event); | ||
| setRowIndex(oldIndex); | ||
| } catch (Exception multipleIndexes) { | ||
| } catch (NumberFormatException multipleIndexes) { |
There was a problem hiding this comment.
Previously all type of exceptions were handled, now it is only NumberFormatException, is it enough?
geopossachs
commented
May 1, 2020
| int oldIndex = getRowIndex(); | ||
| int index = Integer.valueOf(indexes); | ||
| setRowIndex(index); | ||
| setRowIndex(indexList.get(0)); |
There was a problem hiding this comment.
the bugfix for #878 - split array with regex and take the first element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.