jsf 4.0 compatibility #1191
jsf 4.0 compatibility #1191
Conversation
|
Whow! That looks like a tremendous amount of work. Thank you very much! I'll try to review your pull request this week-end. I hope I manage to reach out to the owner of the project, so we can publish a new version and update the showcase. Are you still working on the PR, or is it ready for merging? |
|
Just out of curiosity: did you use my Eclipse plugin? |
geopossachs
added
enhancement
JSF fwk
build system
breaking change
dependencies
|
it looks really nice 👍 @stephanrauh the code changes looks fine for me. |
|
@cdberkstresser I guess you're more competent to answer the question, but I'll try nonetheless: I've seen renamed variables in the minified code. So I suppose there might be a better minifier involved - or a newer version of the minifier we used. |
|
i check the imports - the versions matched jakarta-10 👍 source https://mvnrepository.com/artifact/jakarta.platform/jakarta.jakartaee-web-api/10.0.0 |
|
@stephanrauh Thanks! I didn't try an eclipse plugin. The only outstanding issue I'm having is that it builds with gradle but not maven for my PR. I'm not a great build debugger. |
|
How did you compile the library? The Gradle task is not compatible to Java 17, but trying to update Gradle doesn't work either because the new version of Gradle run many new validations. |
|
I've compiled BootsFaces with Java 11 and uploaded it to the snapshot repository of Maven Central as BootsFaces 1.6.0-SNAPSHOT (see https://oss.sonatype.org/content/repositories/snapshots/net/bootsfaces/bootsfaces/1.6.0-SNAPSHOT). |
|
I've pushed your changes as branch "V1.6.0" to the BootsFaces repository. I'm afraid I've forgotten how to compile and run the showcase. I've left the JavaEE world a long time ago. So I need your help. I can publish the final version to Maven Central if someone tells me the version is good, but I can't test it myself. |
|
Cool. I'm not in Java either these days. Just had an old project that needed updating. Maybe others are still using JavaEE? |
|
I can't get the generated build file to work in the sonatype.org link... Not sure what is different. The BootsFaces-OSP-1.6.0-SNAPSHOT.jar that gradle generates for me with |
|
Hm. Strictly speaking, the Sonartype link is not really a link - although it is - but it's meant to be used as a snapshot dependency, as described in #369. I've compiled the Jar with Maven and Java 11 (Eclipse Temurin). |
|
yeah, here's the error I'm getting. It's definitely possible I'm doing something horribly wrong. |
|
That's really a strange error. Most people run into this error message when trying to build a JAR file with a manifest file that doesn't match the correct format. I guess that's not what you're doing. Maybe my manifest file is broken, but that'd be unexpected, too. Strange. Can you add more lines to the stacktrace so I can see the context? |
|
Here's everything. |
|
Holy moly... the manifest file is really broken, and it seems to have been caused by my Java version (see below - there seems to be a line feed in the version number). At the moment, I'm very busy, so it might take two or three weeks until I try again. Stay tuned! And nudge me if you don't hear from me for a long time. :) |
|
No worries! Thanks so much for taking a look at it. I can build locally for debugging. |
|
@stephanrauh i have the same error with your latest build and the jar. But a take your older jakarta 9 build and bring the showcase with this import up to wildfly 28 and the jakarta-framework on my fork at frist -> https://stage-showcase.bootsfaces.de/miscellaneous/Video.jsf in this page with the video for example i found something in one .js file, so i believe for jakarta 10 we need also the changes like in the mavenResources/META-INF/resources/bsf/js/bsf.js file here for the change form "jsf." to "faces." |
|
@stephanrauh i have add on your working brunch some small changes - one to fix the linebreak error in the manifest and an other to switch to CDI-Beans instead of the deprecated ManangedBeans - have a nice day |
|
@geopossachs But you didn't push it, did you? At least I don't see your changes yet. BTW: "brunch" made my day! |
|
@stephanrauh please take a look to https://github.com/TheCoder4eu/BootsFaces-OSP/commits/V1.6.0 |
|
@stephanrauh i have open a folling MR, witch include our changes too, here #1194 |
I'm able to build with gradle, and it works for my jsf 4.0 project that I upgraded.