Fix for dataTable regading columns with rendered="false" #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the generation of column definitions respect the children being rendered or not - if there are column definitions for columns that are not rendered this causes a JavaScript error.
vsvetoslavov
changed the title
|
@vsvetoslavov First of all, please apologize we didn't review your pull request earlier. These things shouldn't happen - but obviously, they do happen. Thank you very much for your pull request! |
|
As for the PR itself: looks fine by me. It's interesting to learn I've repeated the same code no less than four times. That, in turn, helped to obscure the bug. Let's merge the PR! |
stephanrauh
reviewed
Dec 11, 2017
Closed
|
@stephanrauh thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the generation of column definitions respect the children being rendered or not - if there are column definitions for columns that are not rendered this causes a JavaScript error.
Issue: #848