-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes in b:panel, b:dropMenu and b:selectOneMenu #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.E. <b:panel col-md="6" collapsible="false"> </b:panel>
Small hack, if there is no dot found in expression. i.E. <ui:param name="calculatedAge" value="#{ !empty ref ? util.getAgeAsString(ref.birthday) : '' }" /> <b:inputText id="ageDisplay" span="2" value="#{ calculatedAge }" readonly="true" disabled="true" renderLabel="true" label="Age" />
This fixes a wrong class assignment, if a dropmenu is added inside a ui:repeat as part of another DropMenu. Now the correct class dropdown-submenu will be assigned <b:navBar ...> <b:navbarLinks > <b:dropMenu ....> <ui:repeat var="subDropMenu" value="#menuHandler.dropmenus}"> <b:dropMenu value="#{ subDropMenu.displaylabel }" > .... </b:dropMenu> </ui:repeat> </b:dropMenu> </ui:repeat> </b:navbarLinks>
Fix wrong display of panel collapse icon, if panel header contains a link <b:panel collapsible="false"> <f:facet name="heading"> <i class="fa fa-battery-three-quarters" style="padding-right:20px" /> <h:outputText value="Battery charge left: 75% " /> <b:link style-class="some-class" onclick="alert('clicked!'); return false;" value="Click this link to show an alert box." /> <b:badge style="margin-left:10px; background-color:#5cb85c" value="good" /> </f:facet> .... </b:panel>
<b:selectOneMenu value="#{ vereinSession.verein }"> <ui:remove>v is entity referencing a record of the table verein</ui:remove> <f:selectItems value="#{ managerVerein.list() }" var="v" itemValue="#{v}" itemLabel="#{ v.name }" /> </b:selectOneMenu>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs I've detected in the current bootsfaces.