Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in b:panel, b:dropMenu and b:selectOneMenu #915

Merged
merged 20 commits into from
Feb 19, 2018

Conversation

mtvweb
Copy link

@mtvweb mtvweb commented Feb 16, 2018

This fixes some bugs I've detected in the current bootsfaces.

  1. Panel collapse icon appears, if f:facet header contains a link, even if it is not collapsible
  2. Fix panel in responsive layout
  3. Fix usage of object values in b:selectOneMenu
  4. Fix detection of b:dropMenu inside another b:dropMenu if it is added by an ui:repeat

jens and others added 20 commits April 29, 2017 10:14
i.E.

<b:panel col-md="6" collapsible="false">
</b:panel>
Small hack, if there is no dot found in expression. i.E. 

<ui:param name="calculatedAge"
  value="#{ !empty ref ? util.getAgeAsString(ref.birthday) : '' }" />
<b:inputText id="ageDisplay" span="2"
value="#{ calculatedAge }" readonly="true" disabled="true"
renderLabel="true" label="Age" />
This fixes a wrong class assignment, if a dropmenu is added inside a ui:repeat as part of another DropMenu. Now the correct class dropdown-submenu will be assigned

<b:navBar ...>
	<b:navbarLinks >
		<b:dropMenu ....>
			<ui:repeat var="subDropMenu" value="#menuHandler.dropmenus}">
				<b:dropMenu value="#{ subDropMenu.displaylabel }" >
					....
				</b:dropMenu>
			</ui:repeat>
		</b:dropMenu>
	</ui:repeat>
</b:navbarLinks>
Fix wrong display of panel collapse icon, if panel header contains a link

<b:panel collapsible="false">
  <f:facet name="heading">
    <i class="fa fa-battery-three-quarters" style="padding-right:20px" />
    <h:outputText value="Battery charge left: 75% " />
   <b:link style-class="some-class" onclick="alert('clicked!'); return false;" value="Click this link to show an alert box." />
    <b:badge style="margin-left:10px; background-color:#5cb85c" value="good"  />
  </f:facet>
....
</b:panel>
<b:selectOneMenu value="#{ vereinSession.verein }">
        <ui:remove>v is entity referencing a record of the table verein</ui:remove>
	<f:selectItems value="#{ managerVerein.list() }" var="v"
		itemValue="#{v}" itemLabel="#{ v.name }" />
</b:selectOneMenu>
@stephanrauh stephanrauh added this to the v1.5.0 milestone Feb 16, 2018
@stephanrauh stephanrauh merged commit 1ed8f58 into TheCoder4eu:master Feb 19, 2018
@TheCoder4eu TheCoder4eu mentioned this pull request Jul 14, 2018
@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.3.0 Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants