Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CB,,{board} will not match correctly #75

Open
wishbone1138 opened this issue Aug 4, 2024 · 3 comments
Open

[BUG] CB,,{board} will not match correctly #75

wishbone1138 opened this issue Aug 4, 2024 · 3 comments

Comments

@wishbone1138
Copy link

CB,,General or any other board does not appear to do anything for me. It just tells me that no bulletins are available on the general board but when I go there directly I can clearly see one there. Am I using this QC wrong?

@wishbone1138 wishbone1138 changed the title Check board quick command [BUG] CB,,{board} will not match correctly Aug 6, 2024
@wishbone1138
Copy link
Author

wishbone1138 commented Aug 6, 2024

Found the bug, the case is always lowered for command processing which will cause the select command for get_bulletins to fail because all the default boards start with an uppercase character. Number of ways to fix this.. The fix I have right now ads a "COLLATE NOCASE" to the end of the SELECT command for get_bulletin to make the query case insensitive.

    c.execute("SELECT id, subject, sender_short_name, date, unique_id FROM bulletins WHERE board = ? COLLATE NOCASE", (board,))

@kizeren
Copy link
Contributor

kizeren commented Aug 23, 2024

This happens to not only pb,, but also for adding channels. Everything gets set to lower case instead of case SEsnsItiVe.

@kizeren
Copy link
Contributor

kizeren commented Aug 23, 2024

This line message = message.lower().strip() Breaks most input in the message due to it converting caps to lower.

Using elif choice == 'p' or choice =='P': instead of elif choice =='p': Should fix this.

Would have to do this for any input that uses message.lower.
I should have sometime this weekend to make the changes and do a bit of testing before I do a pull request.

kizeren added a commit to kizeren/TC2-BBS-mesh that referenced this issue Aug 23, 2024
…fix for all lower case board names not showing up.
TheCommsChannel added a commit that referenced this issue Sep 26, 2024
Bug #75 message.lower() breaks adding channels.  Add a fix for all lo…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants