Replace deprecated functions in LLVM14 with new ones #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytoml
changed the title
Open
TheDan64
reviewed
Aug 26, 2022
TheDan64
reviewed
Aug 26, 2022
TheDan64
reviewed
Aug 26, 2022
|
Sorry I forgot remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All functions deprecated since llvm14 are replaced with recommended alternatives.
Other deprecations (e.g.
LLVMSetCurrentDebugLocationinbuilder.rs, deprecated since llvm9.0 ) are untouched.Related Issue
I thought it might fix SEGV in #343, but actually it doesn't.
However, such deprecation removal is always recommended and seems to have no room to argument, I just have directly opened this issue 😃.
How This Has Been Tested
I have run test on Ubuntu22.04 LTS (x86_64 VM instance).
Since this is change only related to
llvm14-0feature, I tested with:cargo test --target=x86_64-unknown-linux-gnu --features=llvm14-0 --allAll tests and doctests are successfully passed.
Breaking Changes
It does not break existing APIs, but I added implementation of
AsTypeRefforCallableValuein order to get function type because it's required byLLVMBuildCall2andLLVMBuildInvoke2.Checklist