fix: allow call of set_body on none opaque structs
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to remember why we added this in the first place... maybe it was an issue in LLVM 3.X? 🤔 |
TheDan64
reviewed
May 12, 2023
| field_types.as_mut_ptr(), | ||
| field_types.len() as u32, | ||
| packed as i32, | ||
| ); | ||
| } | ||
|
|
||
| is_opaque |
There was a problem hiding this comment.
Do you think there's any value in returning whether it was opaque, anymore?
There was a problem hiding this comment.
Probably no. I'm keeping this just to make sure the consistency of the function signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow call of
set_bodyon none opaque structsRelated Issue
#417
How This Has Been Tested
Added some test cases in
tests/all/test_types.rs. There seems to be a issue in changing thepackedstatus of a non-opaque type(at least on my pc - a M1 macbook pro), but changing its body is working as expected.Checklist