Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support LLVM 18 #483

Merged
merged 14 commits into from
Mar 31, 2024
Merged

WIP: Support LLVM 18 #483

merged 14 commits into from
Mar 31, 2024

Conversation

xermicus
Copy link
Contributor

@xermicus xermicus commented Mar 14, 2024

Description

Support LLVM 18.

Related Issue

#482

How This Has Been Tested

Option<Breaking Changes>

Checklist

  • Introduce feature flags

  • Wait out

    • next llvm-sys release supporting LLVM 18
    • LLVM 18 binary releases to run tests on CI
  • Guard removed API methods and make test suite pass

  • Implement added functionality

    • Getting and setting tail, musttail, and notail attributes on call instructions
    • Implmented a safe wrapper around LLVMCreateTargetMachineWithOptions
    • New flags: LLVMGetNNeg, LLVMSetNNeg, LLVMGetIsDisjoint, LLVMSetIsDisjoint, LLVMGetFastMathFlags, LLVMSetFastMathFlags, LLVMCanValueUseFastMathFlags
    • Operand Bundles We don't need this right now, can I leave this open for a future PR?
  • I have read the Contributing Guide

xermicus and others added 13 commits March 11, 2024 14:43
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
@vcfxb
Copy link

vcfxb commented Mar 20, 2024

After a little poke, llvm-sys now has updated to support LLVM 18

Signed-off-by: xermicus <cyrill@parity.io>
@xermicus
Copy link
Contributor Author

Great, now I'm basically just waiting for an ubuntu build to use on CI

@xermicus xermicus marked this pull request as ready for review March 26, 2024 08:39
@xermicus
Copy link
Contributor Author

I'm not sure what's going on with linux x86 binary LLVM releases, however the test suite passes locally for me. @TheDan64 the PR is ready to receive a review :)

@TheDan64 TheDan64 self-requested a review March 31, 2024 21:32
@TheDan64
Copy link
Owner

@xermicus wdym by the binarys? Tests seem to be working. Or was this an intermittent thing?

Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheDan64 TheDan64 merged commit b74d272 into TheDan64:master Mar 31, 2024
16 checks passed
@TheDan64
Copy link
Owner

Oh, there's no build check for LLVM 18, could you please add one @xermicus

@TheDan64 TheDan64 linked an issue Apr 1, 2024 that may be closed by this pull request
@xermicus xermicus deleted the llvm18 branch April 3, 2024 09:33
@xermicus
Copy link
Contributor Author

xermicus commented Apr 3, 2024

@TheDan64 yep I have it on my radar

@Pat-Lafon
Copy link
Contributor

Brew just got LLVM 18, so maybe this has tricked through the ecosystem now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support LLVM 18.1
4 participants