Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update humanoid-character-profile.ftl #123

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

A-z-z-y
Copy link
Contributor

@A-z-z-y A-z-z-y commented Jan 4, 2025

Fixes the pronouns in the character preview to not show they/them pronouns for characters that use it/its

Description

This just adds another condition in the fluent file that controls the character preview text.

Essentially, characters that use it/its pronouns will go from:

"This is [character]. They are X years old."

to

"This is [character]. It is X years old."


TODO

  • Probably test it, maybe.

Changelog

🆑 Azzy

  • fix: Fixed they/them pronouns being displayed for it/its characters in the character preview.

Fixes the pronouns in the character preview to not show they/them pronouns for characters that use it/its
Copy link
Contributor

@sleepyyapril sleepyyapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you think we test?

@A-z-z-y
Copy link
Contributor Author

A-z-z-y commented Jan 4, 2025

image
Okay, yep, it works.

@sleepyyapril sleepyyapril merged commit 44125cf into TheDenSS14:master Jan 4, 2025
13 of 14 checks passed
sleepyyapril added a commit that referenced this pull request Jan 4, 2025
@A-z-z-y A-z-z-y deleted the fix-pronouns branch January 4, 2025 18:53
VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this pull request Jan 5, 2025
# Description

**(Use a MERGE COMMIT, not squash if possible to ~~avoid~~ reduce merge
conflicts for our downstream)**

Cherry-picks some PRs from The Den:

- TheDenSS14/TheDen#8
- TheDenSS14/TheDen#31
- TheDenSS14/TheDen#108
- TheDenSS14/TheDen#116
- TheDenSS14/TheDen#117
- TheDenSS14/TheDen#123
- TheDenSS14/TheDen#124

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: The Den Contributors
- fix: Put actual prescription lenses in the prescription medhuds and
sechuds (by KyuPolaris)
- add: Added the CMO turtleneck and head mirror to the CMO loadouts. (by
sleepyyapril, KyuPolaris)
- add: Added an armored trenchcoat for the Captain. Enjoy your swag! (by
Rosycup)
- fix: Fixed uneven pants leg on summer security uniforms. (by Rosycup)
- add: Added the Captain's Combat Gas Mask, for those more fond of close
encounters. (by Rosycup)
- tweak: Added the Captain's Trenchcoat to the other captain locker
variants. (by Rosycup)
- fix: Fixed they/them pronouns being displayed for it/its characters in
the character preview. (by Azzy)

---------

Co-authored-by: flyingkarii <123355664+flyingkarii@users.noreply.github.com>
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
sleepyyapril added a commit to sleepyyapril/TheDen that referenced this pull request Jan 8, 2025
Fixes the pronouns in the character preview to not show they/them
pronouns for characters that use it/its

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This just adds another condition in the fluent file that controls the
character preview text.

Essentially, characters that use it/its pronouns will go from:

"This is [character]. They are X years old."

to

"This is [character]. It is X years old."

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Probably test it, maybe.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Azzy
- fix: Fixed they/them pronouns being displayed for it/its characters in
the character preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants