Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've been working with PolyMc with Skerit for about 2 and a half months now and here implemented two changes I find necessary.
The first is a change with the GSON item & block model reader to make the
rotation
andtintindex
tags optional and thus not put into every file. I found this necessary as I was having troubles implementing DyeableItems that had only some parts of it dyeable (thetintindex: 0
tags everywhere made the whole thing colored regardless of what I fed into it).The second change is one I found necessary because I was making an item that had an override to
BlockItem.getTranslationKey
and the Heart of the Sea item was having its rarity poke through and make the name yellow. I found it simpler to just swap it out with a different item rather than chase down the cause of that bug.