Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small compatibility changes #240

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

JadedBanana
Copy link
Contributor

Hello! I've been working with PolyMc with Skerit for about 2 and a half months now and here implemented two changes I find necessary.

The first is a change with the GSON item & block model reader to make the rotation and tintindex tags optional and thus not put into every file. I found this necessary as I was having troubles implementing DyeableItems that had only some parts of it dyeable (the tintindex: 0 tags everywhere made the whole thing colored regardless of what I fed into it).

The second change is one I found necessary because I was making an item that had an override to BlockItem.getTranslationKey and the Heart of the Sea item was having its rarity poke through and make the name yellow. I found it simpler to just swap it out with a different item rather than chase down the cause of that bug.

@JadedBanana
Copy link
Contributor Author

Since creating this pull request, I've added two fixes:

I removed the Count attribute being sent in clientItems' PolyMcOriginal tag, since that was preventing clean item stacking while being wholly redundant as it's overwritten by the actual item count anyways.

Secondly, I added a priority list to model override sorting during resource pack creation. I encountered a problem while making a second custom compass where the second compass' item was completely static and ignored rotation. I found that this was because the override sorting was considering the angle of 0.953125 being below the custom_model_data of 2.0, and thus putting the base override without the angle at the very end, nullifying the other overrides. This change I added makes the sorting algorithm consider the custom_model_data FIRST, then sort by everything else.

@TheEpicBlock
Copy link
Owner

Sorry for taking this long to respond, the changes look good! Thank you :D

@TheEpicBlock TheEpicBlock merged commit 9c4ac65 into TheEpicBlock:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants