-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Graphs #117
Feat: Graphs #117
Conversation
@davidoort @cabljac does this look good? anything you guys wanna add/modify before I write docs and tests? |
I'm afk atm, maybe @Dabolus can have a look? This sounds really sick though! Thanks a ton for the contribution 🙏 |
maybe a removeNode would be useful. My DAG stuff i'm using in an existing project, so I may take that code and put it elsewhere :) |
I'll add that |
I really want to enable streaming for this. Rn all I can think of a special functions called |
Streaming support and remove node added |
Gonna need an illustration for the readme |
@davidoort @Dabolus @EPMatt rebiew plis? 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective it looks good to me!
However, I noticed that sometimes the plugin is referred to as genkitx-graph
while other times it's referred to as genkitx-graphs
(plural). Can you uniform the names please?
fixed |
@davidoort @EPMatt rebiew plis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long, appreciate the patience and amazing contribution! So stoked to try this!
@all-contributors add @debkanchan as a code and docs contributor |
I've put up a pull request to add @debkanchan! 🎉 |
This pull request is related to:
I have checked the following:
Description:
This PR enables devs to build directed graphs like LangGraph on top of flows to provide a foundation for building agents with Genkit.
Notable points: