Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crtsh Analyzer: crt.sh result is a nested list #410

Closed
sprungknoedl opened this issue Jan 22, 2019 · 1 comment
Closed

Crtsh Analyzer: crt.sh result is a nested list #410

sprungknoedl opened this issue Jan 22, 2019 · 1 comment
Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related
Milestone

Comments

@sprungknoedl
Copy link
Contributor

Request Type

Bug

Work Environment

N/A

Description

The crt.sh result gets wrapped in a list when parsing the json, but the json returned from crt.sh is already a list. This results in a nested list:

Example (truncated for brevity):

{
  "summary": {
    "taxonomies": [
      {
        "predicate": "Certificates",
        "namespace": "crt.sh",
        "value": "1",
        "level": "info"
      }
    ]
  },
  "full": {
    "certobj": {
      "domain": "example.com",
      "result": [
        [
          {
            "not_after": "2020-12-02T12:00:00",
            "min_entry_timestamp": "2018-11-29T13:44:14.118",
            "min_cert_id": 987119772,
            "issuer_ca_id": 1191,
            "name_value": "www.example.com",
            "issuer_name": "C=US, O=DigiCert Inc, CN=DigiCert SHA2 Secure Server CA",
            "not_before": "2018-11-28T00:00:00"
          }
        ]
      ]
    }
  },
  "success": true,
  "artifacts": [],
  "operations": []
}
@nadouani nadouani added the category:bug Issue is related to a bug label Jan 30, 2019
@nadouani nadouani added this to the 1.15.2 milestone Jan 30, 2019
@nadouani
Copy link
Contributor

This should be fixed by #411

@nadouani nadouani added the scope:analyzer Issue is analyzer related label Jan 30, 2019
@3c7 3c7 closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related
Projects
None yet
Development

No branches or pull requests

3 participants