Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] DNSDB Analyzer Python 3 incompatability #613

Closed
milesflo opened this issue Feb 11, 2020 · 4 comments
Closed

[Bug] DNSDB Analyzer Python 3 incompatability #613

milesflo opened this issue Feb 11, 2020 · 4 comments
Assignees
@jeromeleonard
Labels
category:bug Issue is related to a bug
Milestone
2.7.0

Comments

@milesflo
Copy link

Describe the bug
Upgrading DNSDB's shebang to python3 wasn't enough to get it working... There's a lot of python2 quirks still left in the source code.

Notes:
While it would be best practice to isolate this fix to a single PR, I'm debugging this using tools I've created as part of my other PR and will be bundling this fix in with that.
@milesflo milesflo added the category:bug Issue is related to a bug label Feb 11, 2020
@milesflo milesflo mentioned this issue Feb 11, 2020
Closed
4 tasks
@milesflo
Copy link
Author

Potential fix at commit: b64ca1b

@jeromeleonard
Copy link
Contributor

Hi,

thank for seeing that, and the fix submitted. I am about to release a hot fix/2.4.1. Could you please submit a PR with just the fix for DNSDB so that I can merge it in it ?

Regards,

jeromeleonard added a commit that referenced this issue Feb 11, 2020
@jeromeleonard
#613 revert to python2
6e3f27f
@milesflo
Copy link
Author

@jeromeleonard #696

@jeromeleonard jeromeleonard added this to the 2.6.0 milestone Feb 24, 2020
@jeromeleonard jeromeleonard self-assigned this Feb 28, 2020
@jeromeleonard jeromeleonard modified the milestones: 2.6.0, 2.7.0 Mar 18, 2020
@garanews
Copy link
Contributor

fixed in 2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromeleonard jeromeleonard

Labels
category:bug Issue is related to a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
3 participants
@jeromeleonard @milesflo @garanews