Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AbuseIPDB analyzer #400

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Added AbuseIPDB analyzer #400

merged 3 commits into from
Feb 13, 2019

Conversation

mlodic
Copy link
Contributor

@mlodic mlodic commented Jan 3, 2019

Related to issue #353

@mlodic mlodic mentioned this pull request Jan 3, 2019
Closed
@saadkadhi saadkadhi added this to the 1.16.0 milestone Feb 11, 2019
@saadkadhi saadkadhi added category:new-analyzer New analyzer submitted status:needs-template Analyzer still needs a template for TheHive and removed scope:analyzer Issue is analyzer related labels Feb 11, 2019
@saadkadhi
Copy link
Contributor

Hi @mlodic. Thank you for your contribution. Can you please provide short and long report templates for this new analyzer?

@mlodic
Copy link
Contributor Author

mlodic commented Feb 11, 2019

I'm writing them in a few days. I'll comment this issue once done.

@3c7 3c7 merged commit a20ce52 into TheHive-Project:develop Feb 13, 2019
@3c7
Copy link
Contributor

3c7 commented Feb 13, 2019

Already merged the analyzer files. Do you need help with the templates?

@3c7 3c7 self-assigned this Feb 13, 2019
@mlodic mlodic deleted the develop branch February 14, 2019 16:13
@mlodic mlodic restored the develop branch February 14, 2019 16:17
@mlodic mlodic mentioned this pull request Feb 14, 2019
Merged
@mlodic
Copy link
Contributor Author

mlodic commented Feb 14, 2019

Check this #425 tell and tell me if they are ok. Thanks

@saadkadhi saadkadhi removed the status:needs-template Analyzer still needs a template for TheHive label Feb 14, 2019
nadouani added a commit that referenced this pull request Feb 18, 2019
@nadouani
#400 Update days config type and add default value
dbf8f6c
@nadouani
Copy link
Contributor

I took a look to the analyzer and I will make some changes to it:

  • Improve the summary to display the taxonomy like AbuseIPDB:Records=N
  • Add a new default value to the days config
  • Set the days config type to number instead of string

@nadouani
Copy link
Contributor

For security reasons, the API Key must also been passed as part of the POST body, not as query param (cf. https://www.abuseipdb.com/api)

nadouani added a commit that referenced this pull request Feb 18, 2019
@nadouani
#400 Call AbuseIPDB API using POST, and refine taxonomies
7a25d07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3c7 3c7

Labels
category:new-analyzer New analyzer submitted status:needs-review status:pr-submitted
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mlodic @saadkadhi @3c7 @nadouani