Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to use new API #483

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Conversation

obikao
Copy link

@obikao obikao commented May 22, 2019

This now uses the new HTTPS API for SinkDB, documentation is available here:
https://sinkdb.abuse.ch/api

I wasn't sure how to credit the original author, so I put the original URL in the description. Feel free to change that however you want. This also doesn't have an associated HTML template with it yet. I will be working on that next.

@axpatito
Copy link

Why is this PR using 8 space tabs? Also, if you are working on top of someone else work, you cannot delimit yourself as the author and erase the original author.

@obikao
Copy link
Author

obikao commented May 22, 2019

Well, on my end they are 4 space tabs. But I appreciate your concern, that's a lot of whitespace for the interpreter to compute.

Also, if you looked at the integration's code, this was a complete rewrite of the integration so I didn't really see a problem here...really though I couldn't care less. Just trying to share some of the stuff I fixed for my org...

@3c7 3c7 added scope:analyzer Issue is analyzer related category:enhancement Issue is related to an existing feature to improve status:needs-review status:pr-submitted labels Jun 16, 2019
@dadokkio dadokkio added this to the 2.8.0 milestone May 2, 2020
@garanews garanews changed the base branch from master to release/2.8.0 May 4, 2020 09:06
@dadokkio dadokkio mentioned this pull request May 4, 2020
@dadokkio dadokkio merged commit 52040d7 into TheHive-Project:release/2.8.0 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related status:needs-review status:pr-submitted status:under-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants