Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

317 review type hints for inputoutput objects #318

Merged
merged 2 commits into from
Jan 19, 2024
Merged

317 review type hints for inputoutput objects #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
943e330
#317 - Use latest thehive version for testing
Kamforka Jan 18, 2024
ec84d42
#317 - Review task types
Kamforka Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
@pytest.fixture(scope="session")
def test_config():
return TestConfig(
image_name="kamforka/thehive4py-integrator:thehive-5.2.5",
image_name="kamforka/thehive4py-integrator:thehive-5.2.10",
container_name="thehive4py-integration-tests",
user="admin@thehive.local",
password="secret",
Expand Down
3 changes: 3 additions & 0 deletions thehive4py/types/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class InputTask(InputTaskRequired, total=False):
order: int
dueDate: int
assignee: str
mandatory: bool


class OutputTaskRequired(TypedDict):
Expand All @@ -27,6 +28,7 @@ class OutputTaskRequired(TypedDict):
status: str
flag: bool
order: int
mandatory: bool
extraData: dict


Expand All @@ -51,6 +53,7 @@ class InputUpdateTask(TypedDict, total=False):
order: int
dueDate: int
assignee: str
mandatory: bool


class InputBulkUpdateTask(InputUpdateTask):
Expand Down