#352 - Add deprecation wraning to the 1.x codebase #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will produce warnings like the belows: $ python -c "import thehive4py"
<string>:1: DeprecationWarning: thehive4py v1.x is not maintained anymore as TheHive v3 and v4 are end of life. If you are using TheHive v5 please consider switching to thehive4py v2.x (https://github.com/TheHive-Project/TheHive4py)!or $ python -c "from thehive4py.models import Case"
<string>:1: DeprecationWarning: thehive4py v1.x is not maintained anymore as TheHive v3 and v4 are end of life. If you are using TheHive v5 please consider switching to thehive4py v2.x (https://github.com/TheHive-Project/TheHive4py)! |
|
@Kamforka I believe this might break scripts that are supposed to just print a json to the console. Thoughts? |
|
I would say GO, users can always downgrade to 1.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #352