Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service_number for github actions #216

Closed
wants to merge 1 commit into from

Conversation

bboe
Copy link
Contributor

@bboe bboe commented Jan 5, 2020

Using this coveralls command for parallel github action requires passing a unique service_number field (allowing the job to auto increment).

Using the sha syntax is consistent with how the Coveralls github action names the build so that it can be reported successfully:
https://github.com/coverallsapp/github-action/blob/master/lib/run.js#L43

Here's the commit I tested this against to verify parallel builds group successfully:
praw-dev/prawtools@bb0e00b

@bboe bboe force-pushed the github_actions branch 2 times, most recently from bb0ef6c to bb0e001 Compare January 5, 2020 06:29
@TheKevJames
Copy link
Owner

@bboe thanks for contributing this -- much appreciated! I especially appreciate the link to the test run; thanks!

Looks like there's a few test failures and pieces I need to update in the docs/tests for this change, so I've gone ahead and updated your PR to include those changes and merged that to master.

I have to do a bit of clean-up work pre-merge since someone went and deprecated Python 2.7 and 3.4 while my back was turned, but I'll get this released as a new version shortly!

@bboe bboe deleted the github_actions branch February 12, 2020 06:41
@bboe
Copy link
Contributor Author

bboe commented Feb 12, 2020

Happy to help. Thanks for merging!

@bboe bboe restored the github_actions branch February 12, 2020 06:46
@bboe bboe deleted the github_actions branch May 21, 2020 15:30
@bboe bboe restored the github_actions branch May 22, 2020 00:37
@TimoRoth
Copy link
Contributor

TimoRoth commented Jun 9, 2020

I think the coveralls action changed its behaviour here, and now uses GITHUB_RUN_ID to identify the builds?
At least I am unable to finish a parallel build using this package with it:

Error: Parallel webhook error:Error: {"error":"No build matching CI build number 129178104 found"}, {"error":"No build matching CI build number 129178104 found"}

I am for now working around this by doing this:

GITHUB_SHA="$GITHUB_RUN_ID" GITHUB_REF="" coveralls

@MarvinT
Copy link

MarvinT commented Jul 3, 2020

@TimoRoth
I'm able to get it to run using

      - name: Coveralls
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
          coveralls

if I pip install git+https://github.com/TimoRoth/coveralls-python.git until #227 is pulled in.

An example configuration is here: greenelab/ponyo#11
but its complicated a bit by using a conda installation to deal with R dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants