Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt AddmusicK tweaks for 1.0.10 #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KungFuFurby
Copy link

No description provided.

@doopu
Copy link

doopu commented Jun 9, 2024

This patch adds a PLX and PLY just before RTL, which crashes my hack. addmusick 1.10 doesn't do PHX or PHY in its own patch.asm's MainLabel - it was probably only needed in the 1.06 version of VWF's patch.asm because 1.06 overwrote the X register as part of its processing. I removed the PLX and PLY instructions and the game boots with the cutscenes almost working - I've got some remaining issues which I guess are palette related. [edit: It was, I was using 104 as the test level, and it uses a non-black colour as the background colour.]

Maybe the only required change is actually just the SEP #$30 and the moved main? I'm no expert, I only wanted to report my experience with trying out this pull request locally.

Got a crashing report and the cause was identified as an accidental removal of
the PHY and PHX opcodes.
@KungFuFurby
Copy link
Author

Correct. I accidentally removed the PHX and PHY opcodes, so I restored them at the start of moved_main. My bad. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants