Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permissive -> permissive- #122

Closed
ghost opened this issue Apr 25, 2021 · 1 comment · Fixed by #123
Closed

permissive -> permissive- #122

ghost opened this issue Apr 25, 2021 · 1 comment · Fixed by #123
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Apr 25, 2021

# being a cross-platform target, we enforce standards conformance on MSVC
target_compile_options(Greeter PUBLIC "$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/permissive>")

This line of code is wrong. Being permissive means to let details slide.
permissive- means being conformant.

https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-160

@TheLartians TheLartians added the bug Something isn't working label Apr 26, 2021
@TheLartians
Copy link
Owner

TheLartians commented Apr 26, 2021

Oh yeah, seems to be a typo that slipped through code review in #80. 😱
Thanks for reporting!

TheLartians added a commit that referenced this issue Apr 26, 2021
TheLartians added a commit that referenced this issue Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant