-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed 'No' to 'false' in .clang-format #141
Conversation
Which version of For current version see https://clang.llvm.org/docs/ClangFormatStyleOptions.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the PR! I agree that 'false'
is also better for consistency as we are using for the other flags as well.
@TheLartians |
@ClausKlein good point, I should've checked the documentation before... Thanks for the note! |
This reverts commit d07c18e.
@TheLartians sorry for the delay, I've been extremely busy. You're probably right and the problem comes from the version, I am running 6.0.0 on Ubuntu 18.04. Sorry about this. |
Update: I recently had the chance to install clang-format-10 and everything is working as expected with |
Having
'No'
inside.clang-format
gives me the following error (Ubuntu 18.04):YAML:6:36: error: invalid boolean AlwaysBreakTemplateDeclarations: 'No' ^~~~ Error reading /home/my_path/ProjectName/.clang-format: Invalid argument
'false'
fixes it.