Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace support #10

Merged
merged 9 commits into from
Dec 18, 2020
Merged

add namespace support #10

merged 9 commits into from
Dec 18, 2020

Conversation

MichaelUnknown
Copy link
Contributor

No description provided.

@MichaelUnknown MichaelUnknown changed the title first try add namespace support Dec 14, 2020
@MichaelUnknown
Copy link
Contributor Author

seems to work for me so far, please review :)

@MichaelUnknown
Copy link
Contributor Author

I also added a tests for the namespace case

TheLartians
TheLartians reviewed Dec 18, 2020
View reviewed changes
Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, thanks for the PR! Maybe you could also rename the test dependency dependency2 to something like namespaced_dependency, so it's more clear from the outside what the difference between them is.

.github/workflows/test.yml Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MichaelUnknown
Copy link
Contributor Author

I added the alias creation, everything should be resolved now

@TheLartians
Copy link
Owner

TheLartians commented Dec 18, 2020 •
edited
Loading

Looks great, thanks for the changes!

@TheLartians TheLartians merged commit 3773755 into TheLartians:master Dec 18, 2020
@TheLartians
Copy link
Owner

The namespace support is now released in v1.4. 🎉

@MichaelUnknown MichaelUnknown mentioned this pull request Dec 18, 2020
Closed
@TheLartians TheLartians mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLartians TheLartians TheLartians left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelUnknown @TheLartians